Skip to content

KEP-5538: CSI driver opt-in for service account tokens via secrets field #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

KEP-5538: CSI driver opt-in for service account tokens via secrets field #5615

merged 1 commit into from
Oct 15, 2025
+473 −0

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 6, 2025

  • One-line PR description: CSI driver opt-in for service account tokens via secrets field

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2025
@aramase
Copy link
Member Author

aramase commented Oct 6, 2025

/sig auth
/sig storage
/assign @msau42
/cc @liggitt

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liggitt October 6, 2025 06:13
@enj enj moved this to Needs Triage in SIG Auth Oct 6, 2025
@enj enj added this to SIG Auth Oct 6, 2025
@ibihim ibihim moved this from Needs Triage to In Review in SIG Auth Oct 6, 2025
jpbetz
jpbetz approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For PRR

The handles the introduction of a new optional field to opt-in in the recommended way.

@jpbetz jpbetz mentioned this pull request Oct 10, 2025
Open
7 tasks
msau42
msau42 reviewed Oct 14, 2025
View reviewed changes
@aramase aramase requested a review from msau42 October 14, 2025 04:55
@aramase aramase requested a review from liggitt October 15, 2025 04:36
liggitt
liggitt reviewed Oct 15, 2025
View reviewed changes
liggitt
liggitt reviewed Oct 15, 2025
View reviewed changes
liggitt
liggitt reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, one comment about clarifying drivers can aggressively adopt checking in the secrets map with a fallback to current behavior even before 1.35

@aramase aramase requested a review from liggitt October 15, 2025 15:36
@liggitt
Copy link
Member

liggitt commented Oct 15, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@liggitt
Copy link
Member

liggitt commented Oct 15, 2025

(might want to squash review comments)

@aramase aramase force-pushed the aramase/f/kep_5538_add_alpha branch from 17b32c8 to ec6ff50 Compare October 15, 2025 15:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@aramase
Copy link
Member Author

aramase commented Oct 15, 2025

(might want to squash review comments)

thanks @liggitt! squashed to a single commit.

@msau42 PTAL for sig-storage approval.

msau42
msau42 reviewed Oct 15, 2025
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, jpbetz, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit f70eaa6 into kubernetes:master Oct 15, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 15, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Oct 15, 2025
@aramase aramase deleted the aramase/f/kep_5538_add_alpha branch October 15, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xing-yang xing-yang xing-yang left review comments

@jsafrane jsafrane jsafrane left review comments

@msau42 msau42 msau42 left review comments

@jpbetz jpbetz jpbetz approved these changes

@palnabarun palnabarun Awaiting requested review from palnabarun

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Auth
Status: Closed / Done

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

7 participants

@aramase @liggitt @k8s-ci-robot @jpbetz @xing-yang @jsafrane @msau42